[Code Cleanup]: De-duplicate with google-auth-library-java #50
Labels
code cleanup
Issues for reducing technical debt
Comments
stephenashank
pushed a commit
to stephenashank/google-oauth-plugin
that referenced
this issue
Apr 10, 2019
stephenashank
pushed a commit
to stephenashank/google-oauth-plugin
that referenced
this issue
Apr 15, 2019
stephenashank
pushed a commit
that referenced
this issue
Apr 15, 2019
* Use DataboundSetter throughout except for final field emailAddress for p12 keys. * Update dependencies required for using JCasC plugin in tests. * Remove unneeded imports. * Add test to verify Configuration as Code behavior, along with associated resources. * Temporarily use old format for license header for checkStyle, because this is based on master and not develop. * Preserve backwards compatibility of json keys. * Preverse compatibility of P12 keys. * Avoid using real keys in any form during JCasC tests. * Address checkstyle failures. * Fix indentation misalignment. Mark dependencies only required for CasC tests as optional so that they are not included when using hpi to package or run. * Remove findbugs dependency. Uses spotbugs from the parent pom since switching to the version that uses spotbugs instead of findbugs is required to use CasC. * Add eof new line to test-key.json * Add missing javadoc on JsonServiceAccountConfig. Use correct capitalization and punctuation in javadoc. * Add TODO tracking issue #50 for deduplication. * Fix secret bytes to account for newline in file. * Incorporate PR feedback. * Fix typos in yml comments.
stephenashank
pushed a commit
to stephenashank/google-oauth-plugin
that referenced
this issue
Apr 15, 2019
* Use DataboundSetter throughout except for final field emailAddress for p12 keys. * Update dependencies required for using JCasC plugin in tests. * Remove unneeded imports. * Add test to verify Configuration as Code behavior, along with associated resources. * Temporarily use old format for license header for checkStyle, because this is based on master and not develop. * Preserve backwards compatibility of json keys. * Preverse compatibility of P12 keys. * Avoid using real keys in any form during JCasC tests. * Address checkstyle failures. * Fix indentation misalignment. Mark dependencies only required for CasC tests as optional so that they are not included when using hpi to package or run. * Remove findbugs dependency. Uses spotbugs from the parent pom since switching to the version that uses spotbugs instead of findbugs is required to use CasC. * Add eof new line to test-key.json * Add missing javadoc on JsonServiceAccountConfig. Use correct capitalization and punctuation in javadoc. * Add TODO tracking issue jenkinsci#50 for deduplication. * Fix secret bytes to account for newline in file. * Incorporate PR feedback. * Fix typos in yml comments.
stephenashank
pushed a commit
that referenced
this issue
Apr 15, 2019
* Use DataboundSetter throughout except for final field emailAddress for p12 keys. * Update dependencies required for using JCasC plugin in tests. * Remove unneeded imports. * Add test to verify Configuration as Code behavior, along with associated resources. * Temporarily use old format for license header for checkStyle, because this is based on master and not develop. * Preserve backwards compatibility of json keys. * Preverse compatibility of P12 keys. * Avoid using real keys in any form during JCasC tests. * Address checkstyle failures. * Fix indentation misalignment. Mark dependencies only required for CasC tests as optional so that they are not included when using hpi to package or run. * Remove findbugs dependency. Uses spotbugs from the parent pom since switching to the version that uses spotbugs instead of findbugs is required to use CasC. * Add eof new line to test-key.json * Add missing javadoc on JsonServiceAccountConfig. Use correct capitalization and punctuation in javadoc. * Add TODO tracking issue #50 for deduplication. * Fix secret bytes to account for newline in file. * Incorporate PR feedback. * Fix typos in yml comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like a lot of the models/logic of this project is duplicated with google-auth-library-java. In order to reduce maintenance burden we should invest some effort into re-factoring to use the models/logic from this project: https://github.com/googleapis/google-auth-library-java
The text was updated successfully, but these errors were encountered: