Add project key to cache key #837
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/com/cloudbees/jenkins/plugins/bitbucket/client/BitbucketCloudApiClient.java
Show resolved
Hide resolved
thomas-boehm-tractive
force-pushed
the
fix-cache-key-by-including-project-key
branch
from
52aafe2
to
2f7a1a4
Compare
thomas-boehm-tractive
force-pushed
the
fix-cache-key-by-including-project-key
branch
2 times, most recently
from
4481063
to
c51763a
Compare
thomas-boehm-tractive
force-pushed
the
fix-cache-key-by-including-project-key
branch
from
c51763a
to
b9f51d0
Compare
|
@KalleOlaviNiemitalo @lifeofguenter does anything speak against merging this PR? I think this is a very useful bugfix, as caching without the project key causes issues. |
If a requests is sent with a project key, and the key is not part of the cache key, following requests for other projects will result in the cached repositories for the first project, leading to wrong results
thomas-boehm-tractive
force-pushed
the
fix-cache-key-by-including-project-key
branch
from
2ddc58a
to
a0491ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a requests is sent with a project key, and the key is not part of the cache key, following requests for other projects will result in the cached repositories for the first project, leading to wrong results
Your checklist for this pull request
Fixes #836