Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns modue fails when domain starts with a number #199

Open
sumerion opened this issue May 15, 2021 · 1 comment
Open

dns modue fails when domain starts with a number #199

sumerion opened this issue May 15, 2021 · 1 comment

Comments

@sumerion
Copy link

Hi,

There is a naming convention in the DNS module that fails if the apex domain starts with a number. Google DNS does not allow the zone name to begin with a number.

Maybe there could be a variable that allows for the zone name to be overridden or add a prefix to the naming convention, e.g., root-.

https://github.com/jenkins-x/terraform-google-jx/blob/master/modules/dns/main.tf
managed_zone = replace(var.apex_domain, ".", "-")

Kind regards,
Kris.

@sumerion
Copy link
Author

workaround possible with using
apex_domain_integration_enabled: false
ns recordset in the apex_domain zone needs to be created manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant