Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add needs-rebase label to PRs that need to be rebased on main/master #1436

Open
dippynark opened this issue Mar 16, 2022 · 1 comment
Open

Comments

@dippynark
Copy link
Contributor

Even when a repository is configured to require a rebase before merging, this is not respected by keeper and so it repeatedly errors trying to merge.

Adding support for setting the needs-rebase label for PRs that need to be rebased would fix this since you can add needs-rebase to the tide/keeper missingLabels config.

Grepping through the code, the label is there but never actually used:

$ grep -r NeedsRebase .
./pkg/labels/labels.go:	NeedsRebase     = "needs-rebase"
@msvticket
Copy link
Member

lighthouse is a fork of prow and the prow delegates the needs-rebase functionality to an external plugin
https://github.com/kubernetes/test-infra/tree/master/prow/external-plugins/needs-rebase

I think it would be quite easy to convert that to an external plugin for lighthouse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants