Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trigger jobs only when there is a GUID #1421

Closed
wants to merge 1 commit into from
Closed

fix: trigger jobs only when there is a GUID #1421

wants to merge 1 commit into from

Conversation

ankitm123
Copy link
Member

@ankitm123 ankitm123 commented Feb 16, 2022 •
edited

Signed-off-by: ankitm123 ankitmohapatra123@gmail.com

fixes #1420

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ankitm123
You can assign the PR to them by writing /assign @ankitm123 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ankitm123
fix: trigger jobs only when there is a GUID
d0bcd74 
Signed-off-by: ankitm123 <ankitmohapatra123@gmail.com>
@ankitm123 ankitm123 marked this pull request as ready for review February 16, 2022 21:00
@keskad
Copy link

keskad commented Feb 21, 2022

What's the reason behind this?

@ankitm123
Copy link
Member Author

What's the reason behind this?

Check the linked issue: #1420
It's weird that there are no entries in the lighthouse pod logs. But the duplicate job was created by lighthouse. I am running this in my cluster for a week now, haven't seen a duplicate job since that.

@keskad
Copy link

keskad commented Feb 21, 2022

Damn, sorry I didn't notice the ticket. I see duplicated jobs on my test cluster, but I also see that github fires webhook twice for unknown for me reason.

@ankitm123
Copy link
Member Author

but I also see that github fires webhook twice for unknown for me reason.

For the same event? I dont see that issue though, but wont be surprised if sometimes github does that.

@keskad
Copy link

keskad commented Feb 22, 2022 •
edited

Yes. For the same event. Currently after bootjob passed and webhook was recreated I no longer see this issue. But previously I saw in github panel that github sent request twice in same second. Maybe that could be related somehow. I will let you know if it will happen again.

@ankitm123
Copy link
Member Author

/close
This actually will breal manually triggered pipelines!

@jenkins-x-bot
Copy link
Contributor

@ankitm123: Closed this PR.

In response to this:

/close
This actually will breal manually triggered pipelines!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Random duplicate jobs
3 participants
@ankitm123 @jenkins-x-bot @keskad