Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "tasks" folder should be named "task" #70

Open
hervelemeur opened this issue Dec 9, 2020 · 4 comments
Open

The "tasks" folder should be named "task" #70

hervelemeur opened this issue Dec 9, 2020 · 4 comments

Comments

@hervelemeur
Copy link
Contributor

hervelemeur commented Dec 9, 2020

When running jx pipeline import --url https://github.com/jenkins-x/jx3-pipeline-catalog

I had this error:

loading tekton tasks from: https://github.com/jenkins-x/jx3-pipeline-catalog ...

error: the catalog does not include a 'task' directory at /var/folders/m4/ytp3wjnn1hlbrxt27d64jc3c0000gn/T/jx-git-658269897

@hervelemeur
Copy link
Contributor Author

Here is the error I've got with jx pipeline and a custom catalog:

$ jx pipeline import --url https://github.com/myorg/jx3-pipeline-catalog
loading tekton tasks from: https://github.com/myorg/jx3-pipeline-catalog ...
error: the catalog does not include a 'task' directory at /var/folders/m4/ytp3wjnn1hlbrxt27d64jc3c0000gn/T/jx-git-300798298

@jstrachan
Copy link
Member

yeah - FWIW we never assumed a jenkins x catalog would be usable as a tekton catalog ;) - but it makes sense we should detect them and play nicely

@jstrachan
Copy link
Member

as we'd want to just generate uses:jenkins-x/jx3-pipeline-catalog/... steps now instead of the kpt approach

@hervelemeur
Copy link
Contributor Author

hervelemeur commented Feb 3, 2021

Yeah, just re-read your comment on the PR... Should I fix my pr to actually rename the folder to task or do you prefer them to be better detected in the jx binaries? The former seems more in line with tekton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants