Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vault login command - Setup with k3s #3569

Open
faisalthaheem opened this issue Mar 20, 2022 · 3 comments
Open

Improve vault login command - Setup with k3s #3569

faisalthaheem opened this issue Mar 20, 2022 · 3 comments

Comments

@faisalthaheem
Copy link

Instead of writing this command inline as "try the command vault login myroot ." it should be written with code formatting as below

vault login myroot

Notice the dot "." at the end of the current format, for someone unfamiliar with vault it's easy to mistake that part of the code.

@ankitm123
Copy link
Member

can u open a PR for this?

@faisalthaheem
Copy link
Author

Sure, will do.

@mbergo
Copy link
Contributor

mbergo commented Dec 24, 2022

@faisalthaheem , is this still in your interest? I could start a PR today for this and then you jump on? @ankitm123 , sounds good from your side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants