Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change spelling from converBranch=>convertBranch #305

Closed
wants to merge 1 commit into from
Closed

fix: Change spelling from converBranch=>convertBranch #305

wants to merge 1 commit into from

Conversation

iamjohnnym
Copy link

Fixed func namespace of convertBranch webhook in the gitlab driver.

Fixes #304

@jenkins-x-bot
Copy link

Hi @iamjohnnym. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

Change spelling from converBranch=>convertBranch
4b0814b 
Fixed func namespace of `convertBranch` webhook in the gitlab driver.
Updated parsePushHooks return statement to match
@ankitm123
Copy link
Member

@iamjohnnym can you change the commit message format to docs: change spelling from ..... to pass the semantic check?

@garethjevans garethjevans changed the title Change spelling from converBranch=>convertBranch fix: Change spelling from converBranch=>convertBranch Oct 10, 2022
@garethjevans
Copy link
Member

/ok-to-test

@garethjevans
Copy link
Member

/lgtm

@jenkins-x-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethjevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@garethjevans garethjevans reopened this Oct 10, 2022
@msvticket
Copy link
Member

PR is abandoned. User have not come back and fixed commit message.

/close

@jenkins-x-bot
Copy link

@msvticket: Closed this PR.

In response to this:

PR is abandoned. User have not come back and fixed commit message.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@garethjevans garethjevans

Labels
approved lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Miss spelling of the converBranch func within the gitlab driver webhook pkg.
5 participants
@iamjohnnym @jenkins-x-bot @ankitm123 @garethjevans @msvticket