Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab response codes #302

Open
manuelstein opened this issue Sep 28, 2021 · 0 comments
Open

GitLab response codes #302

manuelstein opened this issue Sep 28, 2021 · 0 comments

Comments

@manuelstein
Copy link

Hi, I'm having trouble with a GitLab v13.x instance and the release API call:
https://example.com/api/v4/projects/<owner>%2F<project>/releases/<sometag>

Any tag that does not exist is responded to with a 403 Forbidden, only tags that exist would work.
This ruins the use of IsScmNotFound.

Would a change make sense that considers "Forbidden" errors as not found?

manuelstein added a commit to manuelstein/jx-changelog that referenced this issue Oct 5, 2021
private gitlab returns forbidden on non-existing tags
see also [my issue on go-scm] regarding response codes(jenkins-x/go-scm#302)
go-scm helper IsScmNotFound() cannot distinguish the gitKind, so aplied the fix in isReleaseNotFound()

Signed-off-by: Manuel Stein <manuel.stein@nokia-bell-labs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant