Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run only Jenkinsfile_updatecli if updatecli is the only folder updated #4891

Open
lemeurherve opened this issue Jan 23, 2024 · 4 comments
Open

Comments

@lemeurherve
Copy link
Member

What feature do you want to see added?

Similar to https://github.com/jenkins-infra/docker-jenkins-weekly and using a script like https://github.com/jenkins-infra/docker-jenkins-weekly/blob/main/bin/select-target-from-modified-files.sh, I propose to run only updatecli and not Jenkinsfile_k8s if only the updatecli folder is updated.

Super low priority, but could be a nice little QoL improvement.

Upstream changes

No response

@dduportal
Copy link
Contributor

At first sight, -1 from me.

If we change the content of the repository, updatecli must always be run even if the manifest is not updated to ensure its target has not been changed and are still valid.

As such, there is no reason to "optimize" in this case (which is different than the build itself)

@lemeurherve
Copy link
Member Author

If we change the content of the repository, updatecli must always be run even if the manifest is not updated to ensure its target has not been changed and are still valid.

I agree, that's the contrary I'm proposing here 🙂

If only the updatecli folder has been changed, there is (IMO) no need to run the complete kubernetes-management pipeline, just the updatecli one.

@dduportal
Copy link
Contributor

If we change the content of the repository, updatecli must always be run even if the manifest is not updated to ensure its target has not been changed and are still valid.

I agree, that's the contrary I'm proposing here 🙂

If only the updatecli folder has been changed, there is (IMO) no need to run the complete kubernetes-management pipeline, just the updatecli one.

my bad, it makes sense then.

I'm not sure about the branch protection though: I'm not aware of branch protection rules which should be conditional though

@lemeurherve
Copy link
Member Author

The main pipeline could just return a success with a message like "INFO: the only folder modified is updatecli, skiping." in that case, WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants