Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Update snack demo #402

Closed
kopax opened this issue Feb 10, 2020 · 2 comments
Closed

[RFR] Update snack demo #402

kopax opened this issue Feb 10, 2020 · 2 comments

Comments

@kopax
Copy link
Contributor

kopax commented Feb 10, 2020

Describe the bug

The snack from the readme is broken.

To Reproduce

Click on that link: https://snack.expo.io/@jemise111/react-native-swipe-list-view

Screenshots

snack on README.md

snack is broken

Related Issues

Open a separate issue for this and I'm happy to try and fix it

@kopax
Copy link
Contributor Author

kopax commented Feb 10, 2020

Hi @jemise111 , As per your request, I have created an updated snack here:

Web view

Web

Android view

Android

iOS view

iOS

It is note based on the original snack, it is based on a blank snack using example.js renamed in components/DemoView.js.

I have also split each example into their own files, so they can be copied and paste more easily.

  • <FlatSwipeListView />: components/examples/FlatSwipeListView.js
  • <AdvancedSwipeListView />: components/examples/AdvancedSwipeListView.js
  • <SectionSwipeListView />: components/examples/SectionSwipeListView.js
  • <DeleteSwipeListView />: components/examples/DeleteSwipeListView.js

I have replaced the class component in components/DemoView.js for a function component because it was not necessary to use a class anymore

All you need to do is create a fork of that snack so you'll have the proper expo account, then update the README.md.

Note: I believe this should also be in the examples.js, but since I wasn't able to run locally, I wasn't able to provide a PR for this.

@kopax kopax changed the title Update snack demo [WIP] Update snack demo Feb 10, 2020
@kopax kopax changed the title [WIP] Update snack demo [RFR] Update snack demo Feb 10, 2020
@jemise111
Copy link
Owner

@kopax Thanks for creating the snack. As I had trouble running some of your examples locally, I decided to just redo them myself. They are now broken into different folders under SwipeListExample/examples and I have fixed the Snack as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants