Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog parsing #781

Closed
wants to merge 1 commit into from
Closed

Conversation

nwithan8
Copy link
Contributor

@nwithan8 nwithan8 commented Oct 3, 2023

Fixed and commented changelog parsing for CI.

Initial comment in skipped "big header" section was causing a key error issue.

Closes #770

@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #781 (dfd4527) into master (4ae2ffe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #781   +/-   ##
=======================================
  Coverage   21.51%   21.51%           
=======================================
  Files          63       63           
  Lines        8542     8542           
  Branches     1572     1572           
=======================================
  Hits         1838     1838           
  Misses       6680     6680           
  Partials       24       24           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm reading this right, it silently drops changes that don't have proper section tags set, which is undesirable.

Changes that shouldn't be included are explicitly tagged as so (and don't show up here), and the presence of an uncategorized PR here is an oversight and should preferably be corrected before making a release.

For now, I think the best way to handle this here is to create a default initial section where the problematic PRs go.


I intend to simplify the release workflow (at the cost of some complexity in the gh actions), same as I recently did in jprm, which would have the bump release PR continually created and updated (with the content created here), but that's out of scope for this particular PR.

@oddstr13 oddstr13 changed the title [chore] Fix changelog parsing Fix changelog parsing Oct 3, 2023
@oddstr13 oddstr13 closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reformat changelog does not support unnamed section
2 participants