Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 template strings are not being highlighted #59

Open
mmwtsn opened this issue Sep 13, 2015 · 4 comments
Open

ES6 template strings are not being highlighted #59

mmwtsn opened this issue Sep 13, 2015 · 4 comments

Comments

@mmwtsn
Copy link
Contributor

mmwtsn commented Sep 13, 2015

This is what I'm seeing:

strings

I've tried this with a handful of themes using version c907b15. Is anyone else seeing highlighted template strings? It looks like this feature was added in #51.

@mmwtsn mmwtsn changed the title ES6 template strings are not working ES6 template strings are not being highlighted Sep 13, 2015
@averted
Copy link
Contributor

averted commented Sep 13, 2015

Yep, this is working fine for me:
screen shot 2015-09-12 at 8 19 58 pm

You have to alter your colorscheme for it to pick up javaScriptTemplate* ids introduced in #51:
screen shot 2015-09-12 at 8 37 40 pm

This is a custom scheme I'm using so it will be different for you, but you get the idea.

@jlipps
Copy link

jlipps commented Sep 14, 2015

just submitted a patch for tomorrow-night in case anyone is using that: chriskempson/vim-tomorrow-theme#44

@mmwtsn
Copy link
Contributor Author

mmwtsn commented Sep 14, 2015

Ah, interesting. Thanks for explaining that.

Rather than patching all of our themes why not highlight javaScriptTemplateString inside this repo? I added a line here to highlight template strings with String and it's working nicely.

Would be happy to open a pull request if that approach makes sense.

@sirbrillig
Copy link

If it's helpful for anyone else who ends up here, adding this to your vimrc should take care of the highlighting for most themes: https://gist.github.com/sirbrillig/fc0630baf46a2c10667f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants