Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include default theme as a dependency #5149

Closed
DirtyF opened this issue Jul 28, 2016 · 4 comments
Closed

Include default theme as a dependency #5149

DirtyF opened this issue Jul 28, 2016 · 4 comments

Comments

@DirtyF
Copy link
Member

DirtyF commented Jul 28, 2016

If a new Jekyll user follows the instructions on the homepage of http://jekyllrb.com/, it fails :/

❯  jekyll -v
jekyll 3.2.0

❯ jekyll new website && cd website

New jekyll site installed in /Users/frank/code/website.

❯ jekyll serve
Could not find gem 'minima' in any of the gem sources listed in your Gemfile or available on this machine.
Run `bundle install` to install missing gems.

From now on you can install gem-based themes but as the default theme shouldn't minima be included to jekyll dependencies?

@DirtyF DirtyF mentioned this issue Jul 28, 2016
4 tasks
@benbalter
Copy link
Contributor

Ran into this via https://travis-ci.org/github/pages-gem/jobs/148042719#L320 when bumping the Pages Gem as well. I'd be in favor of including this (and only this) theme as a dependency, because adding it to the resulting site's Gemfile and then asking the user to run bundle a second time feels like a lot of work for your first site, especially since the dependency is small. Also to note, I'd suggest it be a very loose dependency, so we can bump Minima without needing to bump Jekyll.

@benbalter
Copy link
Contributor

@DirtyF assuming others agree, any interest in starting a quick PR to add it to the Gemspec?

@DirtyF
Copy link
Member Author

DirtyF commented Jul 28, 2016

@benbalter done, I simply expect a minor version bump from default theme when jekyll/minima#6 gets merged.

@parkr
Copy link
Member

parkr commented Jul 28, 2016

Chatted with @benbalter and came to a consensus that we should encourage the following flow:

  1. gem install jekyll
  2. jekyll new my-new-site
  3. cd my-new-site
  4. bundle install <--
  5. bundle exec jekyll serve

Bundler is one of the few tools that I use constantly when working with Ruby projects. While it is "just an implementation detail" that Jekyll uses Ruby, Jekyll uses Ruby and should therefore follow its best practices wherever applicable.

We may need to update documentation and/or update the installation message, but we should be promoting bundler everywhere for the Greatest Good of Our People.

@parkr parkr closed this as completed Jul 28, 2016
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants