-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include default theme as a dependency #5149
Comments
Ran into this via https://travis-ci.org/github/pages-gem/jobs/148042719#L320 when bumping the Pages Gem as well. I'd be in favor of including this (and only this) theme as a dependency, because adding it to the resulting site's Gemfile and then asking the user to run |
@DirtyF assuming others agree, any interest in starting a quick PR to add it to the Gemspec? |
@benbalter done, I simply expect a minor version bump from default theme when jekyll/minima#6 gets merged. |
Chatted with @benbalter and came to a consensus that we should encourage the following flow:
Bundler is one of the few tools that I use constantly when working with Ruby projects. While it is "just an implementation detail" that Jekyll uses Ruby, Jekyll uses Ruby and should therefore follow its best practices wherever applicable. We may need to update documentation and/or update the installation message, but we should be promoting bundler everywhere for the Greatest Good of Our People. |
If a new Jekyll user follows the instructions on the homepage of http://jekyllrb.com/, it fails :/
From now on you can install gem-based themes but as the default theme shouldn't
minima
be included to jekyll dependencies?The text was updated successfully, but these errors were encountered: