-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github_username always generates a link to username at github.com, not enterprise domain #4918
Comments
@aeberbach Hey, it sounds like you're having trouble with the site template. The template isn't supposed to encompass Enterprise at the moment (specifying just a When you run We're in the process of moving the example site out to its own theme for Jekyll 3.2 and we can re-evaluate then how this should be considered. We will want to support this going forward for sure, but for now please edit your copy of /cc @jglovier on an elegant way to support Enterprise user links in the site template. 😄 |
@aeberbach, just a note: when @parkr says
It's a reference to the It is not a reference to the installed gem files you mentioned of Sorry if this is already something you know, but you mentioned editing a gem file in your post, and that's not a good idea. |
Got it - that will work for now, thank you both. |
Sorry for the delayed response. I'll open an issue in the minima gem theme where we can track this. ✨ |
github-pages
My Reproduction Steps
Generate a new jekyll site and push it to gh-pages branch; edit _config.yml to add a github_username to link to the users account. The link generated will be to github.com, not the place your github enterprise repository is hosted. In my case a 404 is the result since my enterprise github username is not the same as my github username.
I think the file that causes this is found in the gem at jekyll-3.1.6/lib/site_template/_includes/icon-github.html - I'm an absolute ruby novice so I don't want to try changing this to see if it makes a difference, have had a broken ruby installation once and don't want to risk it.
The Output I Wanted
links generated should be https://github.myenterprisedomain.com not https://github.com
The text was updated successfully, but these errors were encountered: