Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render Variables does not work if compositing tab "file output" node is in a nodegroup #10

Open
Packsod opened this issue Oct 20, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Packsod
Copy link

Packsod commented Oct 20, 2023

As mentioned, I detected this bug and it will work again after ungroup the nodegroup in the compositing tab.

I use the VF_autosaveRender ver2.7.4 with blender3.6.2LTS
but this problem has always existed in previous versions

Pack compositing nodes into groups for easy import into different projects, it's a habit that improves work efficiency.
So other users may encounter similar issues.
I just want to report this tiny bug to make the addon even better, even though it already is!

@jeinselen
Copy link
Owner

Thanks @Packsod! I appreciate it.

Using a preset group for output nodes makes a lot of sense, especially if there are a bunch of connections that need to be maintained. Unfortunately I'm not so sure about feasibility.

The plugin would run into major trouble if there are ever multiple instances of the same group; editing the contents of one would change all of them, and iterating through each group would end up overwriting the original variables on the first render (they'd be permanently lost, as any group after the first would overwrite the original string with the replaced string, mistaking it as the original).

That shouldn't ever be the case—each group would just be saving over the previous group in that scenario—but I'm trying to think through potential issues with traversing node groups and replacing data. It's probably fine, and traversing node groups is probably easier than I fear (haven't needed to do it before!). I'll keep this feature request in mind, but don't want to overpromise. 😊

Thank you again for bringing it to my attention,
John

@jeinselen jeinselen added the enhancement New feature or request label Oct 21, 2023
@jeinselen jeinselen self-assigned this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants