Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest commit causes new sessions to start in normal mode #245

Open
3 tasks done
VeryDampTowel opened this issue Sep 27, 2023 · 1 comment
Open
3 tasks done

Latest commit causes new sessions to start in normal mode #245

VeryDampTowel opened this issue Sep 27, 2023 · 1 comment
Assignees
@jeffreytse
Labels
bug Something isn't working verified This issue was already verified

Comments

@VeryDampTowel
Copy link
Contributor

General information

Basic examination

  • I have read through the README page
  • I have the latest version of zsh-vi-mode
  • I have tested with another terminal program ==> iTerm + Kitty

Problem description

The latest commit (c8ca1a1) breaks the standard functionality. Normally, a new shell session starts in insert mode, but the latest change causes it to start in normal mode.

Reproduction steps

  1. Pull latest version
  2. Open new shell session with zsh-vi-mode running

Expected behavior

Shell session should be in insert mode.

Changing line 3604 to the following will correct the issue.

  case $ZVM_LINE_INIT_MODE in
     $ZVM_MODE_INSERT) ZVM_MODE=$ZVM_MODE_NORMAL;;
     *) ZVM_MODE=$ZVM_MODE_INSERT;;
   esac
VeryDampTowel referenced this issue Sep 27, 2023
@jeffreytse
fix: incorrect ZVM_MODE value after initialization
c8ca1a1
@jeffreytse jeffreytse self-assigned this Sep 27, 2023
@jeffreytse jeffreytse added bug Something isn't working verified This issue was already verified labels Sep 27, 2023
@VeryDampTowel VeryDampTowel mentioned this issue Sep 27, 2023
Merged
jeffreytse added a commit that referenced this issue Sep 28, 2023
@VeryDampTowel @jeffreytse
fix: session starts in normal mode (#245)
a3d7178 
* Resolve "session starts in normal mode" issue

* Update zsh-vi-mode.zsh

---------

Co-authored-by: JT <jeffreytse.mail@gmail.com>
@jeffreytse
Copy link
Owner

Hi @parispjones

This issue has been addressed and settled now. : )

Thanks & Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffreytse jeffreytse

Labels
bug Something isn't working verified This issue was already verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffreytse @VeryDampTowel