Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: force https for connection to cdn #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: force https for connection to cdn #131

wants to merge 1 commit into from

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Sep 27, 2023 •
edited

fix: remove not required charset at script tag

fixes #144

@Rotzbua
fix: force https for connection to cdn
abc08c4 
fix: remove not required charset at script tag
jeffreytse
jeffreytse reviewed Feb 5, 2024
View reviewed changes
Copy link
Owner

@jeffreytse jeffreytse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, https://stackoverflow.com/questions/954327/hidden-features-of-html/960111#960111

@jeffreytse jeffreytse self-assigned this Feb 5, 2024
@jeffreytse jeffreytse added the enhancement New feature or request label Feb 5, 2024
@casperdcl
Copy link
Contributor

yes but cdnjs.cloudflare.com redirects http -> https (it doesn't support http)

@casperdcl
Copy link
Contributor

actually nvm, just checked and it seems you can force http

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Feb 5, 2024

FYI, https://stackoverflow.com/questions/954327/hidden-features-of-html/960111#960111

I know and what is the intention of the comment?

jeffreytse
jeffreytse reviewed Feb 7, 2024
View reviewed changes
Copy link
Owner

@jeffreytse jeffreytse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rotzbua Have you considered the compatability of browsers?

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Feb 7, 2024

@Rotzbua Have you considered the compatability of browsers?

For what case or browser? Netscape?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffreytse jeffreytse jeffreytse left review comments

@casperdcl casperdcl casperdcl approved these changes

Assignees

@jeffreytse jeffreytse

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Insecure connection to CDN
3 participants
@Rotzbua @casperdcl @jeffreytse