fix(canadacomputers): add inStock selector, use english links
#889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jef
approved these changes
Nov 23, 2020
jef
changed the title
inStock selector, use english links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a new Chrome session, the canadacomputers website will use the system locale to set the store language. This will cause an issue if your System is in French. To prevent that, I added the language param in the URLs.
I also added "Online In Stock" selector, because on some product the store will let you pay online, but you can only pickup in store. In the current version it's useless to get an alert for that if you can't select your prefered store. I don't want to receive an alert for a store 2000km from my house.
Testing
To test the multilingual issue:
I guess you can try switching your Browser/System language (lol) or add
&language=frto the URLsTo test the inStock/outOfStock issue:
Find a product that has "Order Online and Pick Up In-Store".
At the moment there's 2x Ryzen 5600x at Kanata, ON, but you can't Order Online and get it shipped.