Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound not playing #86

Closed
stlmike opened this issue Sep 19, 2020 · 5 comments
Closed

Sound not playing #86

stlmike opened this issue Sep 19, 2020 · 5 comments
Assignees

Comments

@stlmike
Copy link

stlmike commented Sep 19, 2020

With the latest the sound stop working for me. I fixed it by editing

notification.ts

removed

if (notifications.playSound === 'true') {
	playSound();
}

And Changed

if (notifications.email.username && notifications.email.password) {
	playSound();
	sendEmail(cartUrl);
}

Sound playing again. something with the if statement is not working right???

@gangwarily
Copy link

Noticed this also. It seems like notifications.playSound was previously being used for the filename of the sound file and now its being incorrectly used for both the filename and true/false condition for whether the sound should be played.

@jef
Copy link
Owner

jef commented Sep 20, 2020

I believe #83 solves this.

@geman220
Copy link
Contributor

Potentially solved in #91

@ththiem
Copy link
Contributor

ththiem commented Sep 20, 2020

This still runs afoul of a limitation in the play-sound library being used that throws this error:
error :: error playing sound: Error: Couldn't find a suitable audio player

Due to the limitation of the library requiring:

  • mplayer
  • afplay
  • mpg123
  • mpg321
  • play
  • omxplayer
  • aplay
  • cmdmp3

To play audio.

@jef jef added the duplicate label Sep 20, 2020
@jef
Copy link
Owner

jef commented Sep 20, 2020

Duplicate of #76. Closing.

@jef jef closed this as completed Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants