Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playstation): add outOfStock label #812

Merged
merged 1 commit into from Nov 16, 2020

Conversation

J-Hinton
Copy link
Contributor

Description

@J-Hinton J-Hinton requested a review from jef as a code owner November 15, 2020 21:43
@TheTabKey
Copy link
Contributor

TheTabKey commented Nov 15, 2020

@J-Hinton
Copy link
Contributor Author

J-Hinton commented Nov 15, 2020

@TheTabKey During testing, I've only seen the API return as JSON - also to note, the PlayStation store also uses the same headers (Accept: */*) and expects to receive JSON... Are you experiencing XML being returned with header Accept: */*?
If so, I'd suggest we can set the HTTP request header to accept only application/json.

@TheTabKey
Copy link
Contributor

@TheTabKey During testing, I've only seen the API return as JSON - also to note, the PlayStation store also uses the same headers (Accept: */*) and expects to receive JSON... Are you experiencing XML being returned with header Accept: */*?
If so, I'd suggest we can set the HTTP request header to accept only application/json.

It works great, sorry about that.

@kyleroath
Copy link

Solid work @J-Hinton! Just tested it now, working flawlessly. Thank you for taking the time to do this man.

@jef
Copy link
Owner

jef commented Nov 16, 2020

Awesome! Thank you!

@jef jef changed the title feat(store): add outOfStock label to PlayStation store feat(playstation): add outOfStock label Nov 16, 2020
@jef jef merged commit eb314af into jef:main Nov 16, 2020
@J-Hinton J-Hinton deleted the fix/playstation-outOfStock branch November 16, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playstation store not working
4 participants