feat(asus): add backoff codes #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially 503, since I'm getting that constantly after 1-2 successful requests. Works fine when adding this status code though.
jef
approved these changes
Nov 13, 2020
jef
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #789
I added 503, plus the usual signals that we're getting rate limited, since I'm getting that constantly after 1-2 successful
requests. Works fine when adding this status code.
Testing
Add
asusto theSTORESenv var. Before this PR I was getting 503s after a minute or two, and now it receives a 503, backs off, and scrapes more slowly. No more 503s!