Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): copy web directory #745

Merged
merged 1 commit into from Nov 10, 2020
Merged

fix(docker): copy web directory #745

merged 1 commit into from Nov 10, 2020

Conversation

picchioni
Copy link
Contributor

Description

Fixes #744
Modified Dockerfile to include the web directory

Testing

  1. Add web directory to Dockerfile
  2. Successfully build container
  3. Launch container and attempt to browse to webserver

New dependencies

None

@picchioni picchioni requested a review from jef as a code owner November 10, 2020 07:16
jef
jef approved these changes Nov 10, 2020
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Thanks for adding this in here.

@jef jef changed the title fix(web): copy web directory to container fix(docker): copy web directory Nov 10, 2020
@jef jef merged commit 0754fec into jef:main Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webserver 404ing
2 participants
@picchioni @jef