Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): support for kabum (amd and rtx 30 series) #727

Merged
merged 10 commits into from Nov 12, 2020
Merged

Conversation

HeitorLM
Copy link
Contributor

@HeitorLM HeitorLM commented Nov 9, 2020

Description

Adds support for brazilian store Kabum (kabum.com.br).
AMD and RTX 30 Series.

Testing

I tested using random in stock items as placeholder and it seems to work just fine.

@HeitorLM HeitorLM requested a review from jef as a code owner November 9, 2020 08:39
@jef jef changed the title feat (store): support for kabum (amd and rtx 30 series) feat(store): support for kabum (amd and rtx 30 series) Nov 9, 2020
@tempestbk
Copy link

Can someone make a request to add Canada Computers to the list of stores?

Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Do you mind adding to the README of the change?

Thanks!

@tempestbk
Copy link

tempestbk commented Nov 10, 2020 via email

@jef
Copy link
Owner

jef commented Nov 10, 2020

I'm not sure how to do it let me do some research. this is completely new to me.

Sounds good! I can do it for you so we can get this in as well. You let me know.

@tempestbk
Copy link

tempestbk commented Nov 10, 2020 via email

@jef jef changed the base branch from main to develop November 10, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants