feat(amazon): add more 3070s #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jef
requested changes
Nov 8, 2020
jef
approved these changes
Nov 9, 2020
jef
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a few 3070s on amazon-us
NEW:
Model for pny: xlr8 uprising
Model for asus: dual (there's two pages for this model at the moment, I went with the less sketchy looking one)
Testing
Only tested OOS logic, couldn't verify in-stock for obvious reasons
Issues
I was running into some error logs for a PNY card, but it appears to be related to the e-buyer automatic link generation, who's logic doesn't apply to amazon cardsUnrelated issue per #694