Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Generate links for all stores #694

Closed
jef opened this issue Nov 5, 2020 · 6 comments
Closed

Regression: Generate links for all stores #694

jef opened this issue Nov 5, 2020 · 6 comments
Assignees

Comments

@jef
Copy link
Owner

jef commented Nov 5, 2020

Description

Currently, when streetmerchant starts up, links are generated for various stores. This behavior shouldn't happen if the user doesn't use those stores.

Refs:

Possible solution

Make sure only links are generated for stores selected.

@jef jef added the type: bug label Nov 5, 2020
@jef jef self-assigned this Nov 5, 2020
@jef jef pinned this issue Nov 5, 2020
@garza
Copy link

garza commented Nov 11, 2020

@jef I was able to get the develop branch searching again by disabling the amazon-uk store, there only seems to be three link entries in there (one test and two ps5 sony), it was causing a hang after displaying "Failed to parse card: PNY GeForce ..." error line.

@jef
Copy link
Owner Author

jef commented Nov 11, 2020

Yeah, this is part of the regression of building links. I haven't spent anytime working on it, but should be fixed in the near future! Thanks for the comment, it will be helpful.

@taefighter
Copy link

Is there a workaround available for this? I have not been able to use streetmerchant for a few days because of this issue. I just get a
"failed to parse..." error and the application stops.

@garza
Copy link

garza commented Nov 16, 2020

@taefighter do a git pull on main, i haven't had a problem since Friday with the latest code

@jef
Copy link
Owner Author

jef commented Nov 16, 2020

Is there a workaround available for this? I have not been able to use streetmerchant for a few days because of this issue. I just get a
"failed to parse..." error and the application stops.

This regression does not prohibit the app from running at all. It just slows down and shows errors at startup.

@taefighter
Copy link

@taefighter do a git pull on main, i haven't had a problem since Friday with the latest code

Thank you for letting me know. I am still getting the parsing error at startup. However, what @jef said tells me I wasn't giving the app enough time to process. I am leaving it running for a while to see if it will work past the errors at the start. Thank you!

@jef jef closed this as completed in 292e360 Nov 22, 2020
@jef jef unpinned this issue Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants