Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amd): add 5950 config #685

Merged
merged 8 commits into from Nov 5, 2020
Merged

feat(amd): add 5950 config #685

merged 8 commits into from Nov 5, 2020

Conversation

njgreb
Copy link
Contributor

@njgreb njgreb commented Nov 5, 2020

Description

Adds support for AMD store and tracking of the Ryzen 5950x (on amd and bestbuy)

Testing

New store and product...just run it?

@njgreb njgreb requested a review from jef as a code owner November 5, 2020 16:12
@MarioAC2
Copy link

MarioAC2 commented Nov 5, 2020

Would love to see this included! Amazing tool

src/store/model/bestbuy.ts Show resolved Hide resolved
src/store/model/bestbuy.ts Show resolved Hide resolved
Nathan Grebowiec and others added 2 commits November 5, 2020 14:42
@stevezub
Copy link

stevezub commented Nov 5, 2020

Thanks for putting this together, njgreb!

If you're up for adding amazon and newegg, here's an attempt at the configs for the 5900 and 5950.

Amazon:

	{
		brand: 'amd',
		cartUrl: 'https://www.amazon.com/gp/aws/cart/add.html?ASIN.1=B08164VTWH&Quantity.1=1',
		model: '5900x',
		series: '5900',
		url: 'https://www.amazon.com/dp/product/B08164VTWH'
	},
	{
		brand: 'amd',
		cartUrl: 'https://www.amazon.com/gp/aws/cart/add.html?ASIN.1=B0815Y8J9N&Quantity.1=1',
		model: '5950x',
		series: '5950',
		url: 'https://www.amazon.com/dp/product/B0815Y8J9N'
	}

Newegg:

	{
		brand: 'amd',
		cartUrl: 'https://secure.newegg.com/Shopping/AddtoCart.aspx?Submit=ADD&ItemList=N82E16819113664',
		itemNumber: '19-113-664',
		model: '5900x',
		series: '5900',
		url: 'https://www.newegg.com/amd-ryzen-9-5900x/p/N82E16819113664'
	},
	{
		brand: 'amd',
		cartUrl: 'https://secure.newegg.com/Shopping/AddtoCart.aspx?Submit=ADD&ItemList=N82E16819113663',
		itemNumber: '19-113-663',
		model: '5950x',
		series: '5950',
		url: 'https://www.newegg.com/amd-ryzen-9-5950x/p/N82E16819113663'
	}

@jef
Copy link
Owner

jef commented Nov 5, 2020

I'll add these in! But this is subject to change in the future.

Thanks for adding!

@jef jef changed the title feat: add amd store and 5950 config feat(amd): add 5950 config Nov 5, 2020
@jef jef merged commit 31a3d8f into jef:main Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants