Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(asus): realtime api #675

Merged
merged 1 commit into from Nov 3, 2020
Merged

Conversation

jbwilliams1
Copy link
Contributor

Description

Fixes #633

Derived from Newegg API realtime lookup code structure

Testing

Tested against in-stock 5700xt and out-of-stock 3070. Does not interfere with normal operation.

New dependencies

None

@jbwilliams1 jbwilliams1 requested a review from jef as a code owner November 3, 2020 18:11
@jbwilliams1 jbwilliams1 changed the title Add realTimeInventoryLookup to Asus Store Model feat: Asus realtime api Nov 3, 2020
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These PRs are really awesome. I really appreciate you taking the time and catching all the XHR requests.

@jef jef changed the title feat: Asus realtime api feat(asus): realtime api Nov 3, 2020
@jef jef merged commit 018784e into jef:main Nov 3, 2020
@drafton
Copy link

drafton commented Nov 4, 2020

Is it possible to apply the same changes to the store asus-de? Or is it not supported there?

@jbwilliams1
Copy link
Contributor Author

@drafton doesn't look like their DE store has this type of API

@drafton
Copy link

drafton commented Nov 4, 2020

Too bad, thanks for checking anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App reporting cards in stock at Asus store when they are not
3 participants