feat: newegg realtime api #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't program in node/javascript anymore, and generally write code in Rust or Python... so not overly familiar with nodejs Whatever you need me to fix let me know. |
Join the club 😆 I'll go over this later today. Thanks for the hard work on this one! |
…m/jbwilliams1/nvidia-snatcher into develop-newegg-realtime-api-fetch
|
Sorry for all of the commits, I was annoyed by the linter not passing :)
|
|
No problem. I appreciate you sticking through it 😀 |
jef
previously approved these changes
Nov 3, 2020
Signed-off-by: Jef LeCompte <jeffreylec@gmail.com>
|
I went ahead and fixed up some dependency conflicts, hope you don't mind. Let's get this in here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added realtime inventory lookup for Newegg cards
Resolves #646
Resolves #643
Testing
Used an in-stock card for the test series, validated it worked on an in-stock and out of stock card. Runs normally on out-of-stock cards
New dependencies
None (well, node-fetch, but it's bundled in)