feat: allow filtering per model by a specific series #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SesioN
changed the title
Makes sense. I imagine someone would use one or the other. |
jef
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Possibility to filter additionally a model by a series.
Use-Case:
Searching for 3 cards: the founders edition 3090, asus strix oc 3080 and 3090.
Both models are generally available for both series. (e.g founders edition 3080, founders edition 3090 etc.)
Example Config for Use-Case:
STORES="asus,nvidia"
SHOW_ONLY_BRANDS="asus, nvidia"
SHOW_ONLY_MODELS="rog strix oc, founders edition:3090"
Result:
nvidia-snatcher searches for: rog strix oc 3080, rog strix oc 3090, founders edition 3090
Limitations
Additional filtering only works for series that are globally enabled and not filtered out by SHOW_ONLY_SERIES.
Testing
New dependencies