Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add PagerDuty Integration #565

Merged
merged 6 commits into from
Oct 23, 2020
Merged

feat: Add PagerDuty Integration #565

merged 6 commits into from
Oct 23, 2020

Conversation

HeavenFox
Copy link
Contributor

Description

Many engineers and operations people use PagerDuty to get paged. This PR adds support for that, so one can get a strong notification when a card gets in stock day or night, overriding any Do Not Disturb setting.

Testing

Tested with my personal PagerDuty account

Create a service and add integration with the Events API v2. Add the integration key to the .env file.

IMG_5868 2

New dependencies

node-pagerduty

@HeavenFox HeavenFox requested a review from jef as a code owner October 22, 2020 02:37
@jef
Copy link
Owner

jef commented Oct 22, 2020

PagerDuty haunts me...

jef
jef previously approved these changes Oct 22, 2020
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution. Thanks!

@jef
Copy link
Owner

jef commented Oct 22, 2020

Lastly, before I merge; do you mind updating the README to include your contribution?

@HeavenFox
Copy link
Contributor Author

Thanks for the reminder! Just updated README

@jef jef merged commit 11ee0bf into jef:main Oct 23, 2020
@HeavenFox HeavenFox deleted the pagerduty branch October 23, 2020 17:29
@c0ns0le
Copy link

c0ns0le commented Oct 23, 2020

small note, the pagerduty referenced in this merge has a dep which needs to be updated for npm-user-validate

                   === npm audit security report ===               
                                                                   
                                                                   
                             Manual Review                         
         Some vulnerabilities require your attention to resolve    
                                                                   
      Visit https://go.npm.me/audit-guide for additional guidance  

Low Regular Expression Denial of Service

Package npm-user-validate

Patched in >=1.0.1

Dependency of node-pagerduty

Path node-pagerduty > npm > npm-user-validate

More info https://npmjs.com/advisories/1572

@jef
Copy link
Owner

jef commented Oct 26, 2020

I did notice this and resolved all but this audit. Probably will need to notify the owner and make a PR here: https://github.com/kmartin-215/node-pagerduty

@veev-code
Copy link

@HeavenFox Thanks for offering this support. Just out of curiosity, is there anything similar to PagerDuty if I just want alarm-like notifications? PagerDuty seems to require a subscription and only offers a 14 day free trial.

@jef
Copy link
Owner

jef commented Nov 6, 2020

Fixed here kmartin-215/node-pagerduty#25

@jef
Copy link
Owner

jef commented Nov 6, 2020

@HeavenFox Thanks for offering this support. Just out of curiosity, is there anything similar to PagerDuty if I just want alarm-like notifications? PagerDuty seems to require a subscription and only offers a 14 day free trial.

I think your best bet it just setting up custom notifications from an email address or SMS or any of the other notification services

@veev-code
Copy link

I think your best bet it just setting up custom notifications from an email address or SMS or any of the other notification services

@jef Makes sense, thanks. I'm primarily relying on Gmail on an iPhone. Any idea how to setup an alarm-like custom notification there?

@HeavenFox
Copy link
Contributor Author

I think your best bet it just setting up custom notifications from an email address or SMS or any of the other notification services

@jef Makes sense, thanks. I'm primarily relying on Gmail on an iPhone. Any idea how to setup an alarm-like custom notification there?

Your best bet might be to use some kind of phone integration, and enable Emergency Bypass for the phone number, if you want to get woken up in the middle of the night.
BTW I got woken up in the middle of the night several times. It's all false positive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants