Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in PCComponentes store #560

Closed
alvarobasi opened this issue Oct 21, 2020 · 5 comments · Fixed by #563
Closed

Bug in PCComponentes store #560

alvarobasi opened this issue Oct 21, 2020 · 5 comments · Fixed by #563
Assignees

Comments

@alvarobasi
Copy link
Contributor

Description

When selecting pccomponentes as one of the stores to track, it doesn't appear in the logs.

I'm using the dockerized application in a Windows 10 machine.

Possible solution

In the pccomponentes.ts file I chose the following labels for checking status:

labels: {
		inStock: {
			container: '#btnsWishAddBuy',
			text: ['Comprar']
		},
		outOfStock: {
			container: '#btnsWishAddBuy',
			text: ['Avísame']
		}
	},

However, testing this container selection in the Chrome Console gives the following output:

console.log($('#btnsWishAddBuy').text());

$Añadir a lista}¥Añadir al carrito
Comprar
]

How does the program filter using the text: ['Comprar'] property? Is there a contains function or something similar? Maybe the breaklines are hurting the algorithm? Or may the error be in the text: ['Avísame'] property with the accent in the i? In that case, leaving the inStock property alone would be the solution.

@xninjax
Copy link
Contributor

xninjax commented Oct 21, 2020

How does the program filter using the text: ['Comprar'] property?

The script is looking for a substring - and your selectors look fine, confirmed to be working against the test-card for me...
image

I see in your PR you've made updates to the model names (to now match project convention). Was this the issue for you?

PS- anyone looking for a zotac right now? 😄
image

@alvarobasi
Copy link
Contributor Author

How does the program filter using the text: ['Comprar'] property?

The script is looking for a substring - and your selectors look fine, confirmed to be working against the test-card for me...
image

I see in your PR you've made updates to the model names (to now match project convention). Was this the issue for you?

PS- anyone looking for a zotac right now? 😄
image

Yep! Exactly. The issue was in the model filtering I was applying, as "tuf gaming" and "tuf oc gaming" doesn't match with the actual labels "tuf" and "tuf oc". With the latest PR this is fixed. My bad! 😅

@jef
Copy link
Owner

jef commented Oct 22, 2020

Thanks @xninjax!

@jef jef closed this as completed Oct 22, 2020
@alvarobasi
Copy link
Contributor Author

Hi @jef ! Remember to review and merge my PR #563 in order to match the model names with the project convention! Thanks!!

@jef
Copy link
Owner

jef commented Oct 22, 2020

Thank you very much @alvarobasi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants