Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Asus (DE) store #551

Closed
Tomson124 opened this issue Oct 20, 2020 · 3 comments
Closed

Add Asus (DE) store #551

Tomson124 opened this issue Oct 20, 2020 · 3 comments
Assignees

Comments

@Tomson124
Copy link
Contributor

Description

When the "Asus" store is selected it always uses the US store which doesn't really work for people outside the US in terms of delivery. Would be good if it would search the store based on the country someone lives.

Possible solution

Maybe we could use the language setting which is currently only used for Nvidia and "calculate" the correct link language abbreviation for the store like e.g. germany --> de

@jef
Copy link
Owner

jef commented Oct 20, 2020

This is more than just locale support, it's seperate store. You can see with other countries, they have completely different store setups, as they may or may not provide the same cards as well.

I'll keep this issue open in hopes that someone will add the Asus store for the specified countries.

Thanks!

@jef jef changed the title "Localize" stores like Asus based on country of residence Add Asus (DE) store Oct 20, 2020
@johnconnor2020
Copy link

This is more than just locale support, it's seperate store. You can see with other countries, they have completely different store setups, as they may or may not provide the same cards as well.

I'll keep this issue open in hopes that someone will add the Asus store for the specified countries.

Thanks!

This person added the german asus store, but you need to approve it.
#528

@jef
Copy link
Owner

jef commented Oct 22, 2020

Resolved with #528

@jef jef closed this as completed Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants