fix: update gigabyte model vision oc
#550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, makes sense. Thanks for updating! |
jef
approved these changes
Oct 20, 2020
jef
changed the title
vision oc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Purely an informational change for anyone looking to filter by Gigabyte's Vision OC card. Following the readme's filter guide for this model results in a filter for a card that doesn't exist.
Testing
Running this while filtering by
gigabytebrand results in searches forvision occards (along with other Gigabyte cards, as expected), but filtering by thevisionmodel like the readme says doesn't result in any searches. Filtering by thevision ocmodel works as expected.