Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): amazon captcha false-positives #54

Merged
merged 2 commits into from Sep 19, 2020
Merged

fix(store): amazon captcha false-positives #54

merged 2 commits into from Sep 19, 2020

Conversation

admon84
Copy link
Contributor

@admon84 admon84 commented Sep 19, 2020

Description

Bandaid fix for amazon captcha page false-positives.

Testing

Running the script after updating and haven't seen any more false-positives for amazon searches yet.

The amazon captcha page looks like this:
success-1600489110104

@admon84 admon84 requested a review from jef as a code owner September 19, 2020 04:32
@admon84
Copy link
Contributor Author

admon84 commented Sep 19, 2020

After running the script for a few hours after this change, I have still seen 2 false positives with amazon captcha pages. It does appear to happen less frequently, but this is just a temporary bandaid solution anyways. I won't be offended if this gets closed without merging.

Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this is just a temporary bandaid solution anyways

Haha, good hack. This will be better until we start resolving pages via tags. I appreciate the PR!

Thanks for the input :)

@jef jef changed the title fix: amazon captcha false-positives fix(store): amazon captcha false-positives Sep 19, 2020
@jef jef merged commit 5c9e0b6 into jef:main Sep 19, 2020
@admon84 admon84 deleted the amazon-bandaid branch September 20, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants