feat: add incognito mode #534
Conversation
src/store/lookup.ts
Outdated
| const context = await browser.createIncognitoBrowserContext(); | ||
| const page = (config.browser.isIncognito ? await context.newPage() : await browser.newPage()); |
There was a problem hiding this comment.
I'd wrap this context within the if statement as well, so we don't create the incognito browser context without needing to.
I'm not sure how you would wrap it in an if statement, but every browser has a BrowserContext by default, so I changed the code to assign context to be either default or incognito. Also, closing the page, closes the default BrowserContext, but you have to close the incognito BrowserContext separately. What do you think? |
This reverts commit 906a961.
|
Ah, that makes a lot of sense to me now. I remember being a little confused when I was playing with the context and passing it around in a feature branch I was working in. Thanks for the explanation! |
Description
Added the ability to use Incognito tabs.
At least with chrome, it uses a cache for sites, incognito forces to reload everything.
This might help better detect when the "add to cart" button is updated.
Testing
Tested with a normal link with "headless:false" to see if it actually opens in "incognito" and it does.
New dependencies