Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAX_PRICE_3080 not working #514

Closed
MrRobot245 opened this issue Oct 13, 2020 · 6 comments
Closed

MAX_PRICE_3080 not working #514

MrRobot245 opened this issue Oct 13, 2020 · 6 comments

Comments

@MrRobot245
Copy link

Description

For Amazon-Ca at least:
Got multiple notifications for a 1800 card when I set my limit to 1300, class selector looks like its still the correct one. Seems like a regression

@jef
Copy link
Owner

jef commented Oct 13, 2020

Interesting. I'll do some debugging when I get the chance. Thanks for the report.

@t-green
Copy link

t-green commented Oct 13, 2020

+1 this happened to me 3 times today too, all Amazon.ca

@xninjax
Copy link
Contributor

xninjax commented Oct 13, 2020

Issue found -
In config.ts, series prices are looking for .env names like "MAX_PRICE_3080"...

	maxPrice: {
		series: {
			3070: envOrNumber(process.env.MAX_PRICE_3070),
			3080: envOrNumber(process.env.MAX_PRICE_3080),
			3090: envOrNumber(process.env.MAX_PRICE_3090)........

But current .env the names are:

MAX_PRICE_SERIES_3070=
MAX_PRICE_SERIES_3080=
MAX_PRICE_SERIES_3090=

I changed the .env name for 3080 to be MAX_PRICE_3080, and modified the test card to use the 3080 as its series. This now works again 👍

image

@jef which convention to go with MAX_PRICE_SERIES_xxxx= or MAX_PRICE_xxxx= ?

@t-green
Copy link

t-green commented Oct 13, 2020

Good eye @xninjax I glossed right over that.

My 2cents: It's easier to update the config.ts variable names to MAX_PRICE_SERIES_XXXX so people can just do a pull, rather than having existing users edit their .env files manually.

@xninjax
Copy link
Contributor

xninjax commented Oct 13, 2020

@t-green very much agree, I'll have a pull request queued and up shortly

@jef
Copy link
Owner

jef commented Oct 13, 2020

WHOOPS! Sorry about that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants