feat: allow multiple microcenter locations #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jef
reviewed
Oct 10, 2020
| const logString = `No MicroCenter location named ${microCenterLocation}, skipping.`; | ||
| logger.warn(logString); | ||
| } else { | ||
| storeId = microCenterLocationToId.get(microCenterLocation)!; |
There was a problem hiding this comment.
Non-null assertion. It was there before I moved this line, not sure if it's still needed.
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
jef
approved these changes
Oct 12, 2020
AdamSaketume26
pushed a commit
to AdamSaketume26/nvidia-snatcher
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #386
In some cases (e.g. Georgia) there are more than one MicroCenter locations nearby, so we'd want to check more than one location.
Testing
Set MICROCENTER_LOCATION variable to "duluth,marietta" and STORES to "microcenter". Verified in the debug logs that links from both locations were loaded into the Store object for MicroCenter. The bot then checked for cards from MicroCenter successfully.