Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for specifying smtp server #458

Merged
merged 1 commit into from Oct 7, 2020
Merged

Conversation

adrian549092
Copy link
Contributor

Description

No issue associated with this feature but could be a solution for #370
The proposed change allows the user to specify an smtp server ip address or fqdn and port in the .env file to use for sending email and sms notifications. In my particular situation, the application resides behind a proxy server which does not allow connections to external smtp servers but I do have a local mail relay agent available for sending emails.

Testing

When SMTP_ADDRESS and SMTP_PORT are left unspecified the application will use the default gmail service and works as normal. When the mentioned variables are set then the application will use the specified settings to connect to an SMTP Relay Agent and send emails. Both of the previously mentioned cases were tested using the available test:notification npm script and I also set the PHONE_NUMBER and PHONE_CARRIER variables in order to confirm that SMS notifications worked as well. All tests succeeded.

SMTP_ADDRESS="<IP ADDRESS OF SMTP SERVER>"
SMTP_PORT=<TCP PORT FOR SMTP SERVER>

@adrian549092 adrian549092 requested a review from jef as a code owner October 5, 2020 22:56
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of the conflicts. It was quite a bit 😅

:shipit:

@jef jef changed the title added support for specifying smtp server feat: add support for specifying smtp server Oct 7, 2020
@jef jef merged commit 160ae37 into jef:main Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants