feat: add support for specifying smtp server #458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No issue associated with this feature but could be a solution for #370
The proposed change allows the user to specify an
smtp server
ip address or fqdn and port in the.env
file to use for sending email and sms notifications. In my particular situation, the application resides behind a proxy server which does not allow connections to external smtp servers but I do have a local mail relay agent available for sending emails.Testing
When
SMTP_ADDRESS
andSMTP_PORT
are left unspecified the application will use the defaultgmail
service and works as normal. When the mentioned variables are set then the application will use the specified settings to connect to an SMTP Relay Agent and send emails. Both of the previously mentioned cases were tested using the availabletest:notification
npm script
and I also set thePHONE_NUMBER
andPHONE_CARRIER
variables in order to confirm that SMS notifications worked as well. All tests succeeded.