New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: max price per series #451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes a lot of sense to me. Just one comment on reporting to the user of breaking change should be sufficient.
Thanks!
added space for deprecated functions in index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you very much for cleaning this up and adding the message.
Description
N/A - max price is for single product; this makes it by product
Updates max price so it is product specific instead of being a single number
Jase/Myanth#7701
Testing
untested but works in theory; don't have an endpoint that breaks the price currently
changes maxPrice to maxPrice3070, maxPrice3080, maxPrice3090