Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): update inStock and maxPrice for newegg, newegg-ca #433

Merged
merged 1 commit into from Oct 3, 2020

Conversation

jeckerman
Copy link
Contributor

Description

Fixes #400

Testing

Verified updated inStock and maxPrice selectors are working correctly, running against multiple products and price ranges for both stores (newegg and newegg-ca)

@jeckerman jeckerman requested a review from jef as a code owner October 3, 2020 05:35
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Thank you very much!

@jef jef changed the title fix(store): updated inStock and maxPrice selectors for newegg, newegg-ca (#400) fix(store): update inStock and maxPrice for newegg, newegg-ca Oct 3, 2020
@jef jef merged commit 628cab1 into jef:main Oct 3, 2020
@ThisIsPita ThisIsPita mentioned this pull request Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snatcher completely missed a huge card drop at newegg about 12 hours ago.
3 participants