fix: remove 3090 drid for DK/FI regions #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the info. Very interesting, why nvidia would have a product page for the FI/DK 3090 if they don't even have a product id for it is beyond me. Hopefully we'll get some in the future. |
|
😢 Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #360 - I've run a script to verify that all other ids are correct; DK/FI does not have a 3090 product id.
[15:48:14] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"austria","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"EUR","value":429},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:14] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"austria","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"EUR","value":719},"series":"3080","sku":"900-1G133-2530-000"} [15:48:15] info :: ℹ [nvidia-debug] [setup (3090)] :: product match: {"country":"austria","displayName":"NVIDIA GEFORCE RTX 3090","price":{"currency":"EUR","value":1549},"series":"3090","sku":"900-1G136-2510-000"} [15:48:15] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"belgium","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"EUR","value":439},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:19] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"belgium","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"EUR","value":719},"series":"3080","sku":"900-1G133-2530-000"} [15:48:20] info :: ℹ [nvidia-debug] [setup (3090)] :: product match: {"country":"belgium","displayName":"NVIDIA GEFORCE RTX 3090","price":{"currency":"EUR","value":1549},"series":"3090","sku":"900-1G136-2510-000"} [15:48:20] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"canada","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"CAD","value":529},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:20] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"canada","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"CAD","value":899},"series":"3080","sku":"900-1G133-2530-000"} [15:48:20] info :: ℹ [nvidia-debug] [setup (3090)] :: product match: {"country":"canada","displayName":"NVIDIA GEFORCE RTX 3090","price":{"currency":"CAD","value":1999},"series":"3090","sku":"900-1G136-2510-000"} [15:48:25] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"czechia","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"CZK","value":11149},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:25] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"czechia","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"CZK","value":18999},"series":"3080","sku":"900-1G133-2530-000"} [15:48:25] info :: ℹ [nvidia-debug] [setup (3090)] :: product match: {"country":"czechia","displayName":"NVIDIA GEFORCE RTX 3090","price":{"currency":"CZK","value":40999},"series":"3090","sku":"900-1G136-2510-000"} [15:48:26] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"denmark","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"DKK","value":3349},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:26] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"denmark","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"DKK","value":5650},"series":"3080","sku":"900-1G133-2530-000"} [15:48:27] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"finland","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"EUR","value":449},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:27] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"finland","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"EUR","value":739},"series":"3080","sku":"900-1G133-2530-000"} [15:48:28] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"france","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"EUR","value":429},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:32] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"france","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"EUR","value":719},"series":"3080","sku":"900-1G133-2530-000"} [15:48:33] info :: ℹ [nvidia-debug] [setup (3090)] :: product match: {"country":"france","displayName":"NVIDIA GEFORCE RTX 3090","price":{"currency":"EUR","value":1549},"series":"3090","sku":"900-1G136-2510-000"} [15:48:33] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"germany","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"EUR","value":429},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:33] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"germany","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"EUR","value":699},"series":"3080","sku":"900-1G133-2530-000"} [15:48:33] info :: ℹ [nvidia-debug] [setup (3090)] :: product match: {"country":"germany","displayName":"NVIDIA GEFORCE RTX 3090","price":{"currency":"EUR","value":1499},"series":"3090","sku":"900-1G136-2510-000"} [15:48:33] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"great_britain","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"GBP","value":389},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:34] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"great_britain","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"GBP","value":649},"series":"3080","sku":"900-1G133-2530-000"} [15:48:34] info :: ℹ [nvidia-debug] [setup (3090)] :: product match: {"country":"great_britain","displayName":"NVIDIA GEFORCE RTX 3090","price":{"currency":"GBP","value":1399},"series":"3090","sku":"900-1G136-2510-000"} [15:48:34] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"ireland","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"GBP","value":389},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:35] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"ireland","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"GBP","value":649},"series":"3080","sku":"900-1G133-2530-000"} [15:48:35] info :: ℹ [nvidia-debug] [setup (3090)] :: product match: {"country":"ireland","displayName":"NVIDIA GEFORCE RTX 3090","price":{"currency":"GBP","value":1399},"series":"3090","sku":"900-1G136-2510-000"} [15:48:35] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"italy","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"EUR","value":439},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:35] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"italy","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"EUR","value":719},"series":"3080","sku":"900-1G133-2530-000"} [15:48:35] info :: ℹ [nvidia-debug] [setup (3090)] :: product match: {"country":"italy","displayName":"NVIDIA GEFORCE RTX 3090","price":{"currency":"EUR","value":1549},"series":"3090","sku":"900-1G136-2510-000"} [15:48:40] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"luxembourg","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"EUR","value":439},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:40] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"luxembourg","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"EUR","value":719},"series":"3080","sku":"900-1G133-2530-000"} [15:48:41] info :: ℹ [nvidia-debug] [setup (3090)] :: product match: {"country":"luxembourg","displayName":"NVIDIA GEFORCE RTX 3090","price":{"currency":"EUR","value":1549},"series":"3090","sku":"900-1G136-2510-000"} [15:48:41] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"netherlands","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"EUR","value":439},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:41] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"netherlands","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"EUR","value":719},"series":"3080","sku":"900-1G133-2530-000"} [15:48:41] info :: ℹ [nvidia-debug] [setup (3090)] :: product match: {"country":"netherlands","displayName":"NVIDIA GEFORCE RTX 3090","price":{"currency":"EUR","value":1549},"series":"3090","sku":"900-1G136-2510-000"} [15:48:41] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"norway","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"NOK","value":4999},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:42] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"norway","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"NOK","value":8000},"series":"3080","sku":"900-1G133-2530-000"} [15:48:42] info :: ℹ [nvidia-debug] [setup (3090)] :: product match: {"country":"norway","displayName":"NVIDIA GEFORCE RTX 3090","price":{"currency":"NOK","value":17000},"series":"3090","sku":"900-1G136-2510-000"} [15:48:42] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"poland","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"PLN","value":1899},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:42] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"poland","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"PLN","value":3279},"series":"3080","sku":"900-1G133-2530-000"} [15:48:43] info :: ℹ [nvidia-debug] [setup (3090)] :: product match: {"country":"poland","displayName":"NVIDIA GEFORCE RTX 3090","price":{"currency":"PLN","value":7029},"series":"3090","sku":"900-1G136-2510-000"} [15:48:43] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"portugal","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"EUR","value":719},"series":"3080","sku":"900-1G133-2530-000"} [15:48:43] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"spain","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"EUR","value":439},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:43] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"spain","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"EUR","value":719},"series":"3080","sku":"900-1G133-2530-000"} [15:48:44] info :: ℹ [nvidia-debug] [setup (3090)] :: product match: {"country":"spain","displayName":"NVIDIA GEFORCE RTX 3090","price":{"currency":"EUR","value":1549},"series":"3090","sku":"900-1G136-2510-000"} [15:48:44] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"sweden","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"SEK","value":4799},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:44] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"sweden","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"SEK","value":7825},"series":"3080","sku":"900-1G133-2530-000"} [15:48:44] info :: ℹ [nvidia-debug] [setup (3090)] :: product match: {"country":"sweden","displayName":"NVIDIA GEFORCE RTX 3090","price":{"currency":"SEK","value":16800},"series":"3090","sku":"900-1G136-2510-000"} [15:48:49] info :: ℹ [nvidia-debug] [setup (test:series)] :: product match: {"country":"usa","displayName":"NVIDIA GEFORCE RTX 2060 SUPER","price":{"currency":"USD","value":399},"series":"test:series","sku":"900-1G160-2560-000"} [15:48:49] info :: ℹ [nvidia-debug] [setup (3080)] :: product match: {"country":"usa","displayName":"NVIDIA GEFORCE RTX 3080","price":{"currency":"USD","value":699},"series":"3080","sku":"900-1G133-2530-000"} [15:48:49] info :: ℹ [nvidia-debug] [setup (3090)] :: product match: {"country":"usa","displayName":"NVIDIA GEFORCE RTX 3090","price":{"currency":"USD","value":1499},"series":"3090","sku":"900-1G136-2510-000"}