Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): twilio client creation #349

Merged
merged 2 commits into from Sep 27, 2020
Merged

Conversation

seanogdev
Copy link
Contributor

Description

Fixes #348

Testing

Ran on my machine

@seanogdev seanogdev requested a review from jef as a code owner September 27, 2020 19:31
@seanogdev seanogdev changed the title fix: Ignore twilio if not configured fix: ignore twilio if not configured Sep 27, 2020
@dyndragon
Copy link

I also tested this, seems to work fine.

@seanogdev seanogdev changed the title fix: ignore twilio if not configured fix(notifications): create twilio client when sending message via twilio Sep 27, 2020
@JeffBuss
Copy link

Can confirm this fixes the issue

@jef
Copy link
Owner

jef commented Sep 27, 2020

thank you. was just about to fix. got dm'd. thank you!!!!!!!!!

@jef
Copy link
Owner

jef commented Sep 27, 2020

Not ideal to create a client over and over, but will fix in a chore later.

@jef jef changed the title fix(notifications): create twilio client when sending message via twilio fix(notifications): twilio client creation Sep 27, 2020
@jef jef merged commit 5414b24 into jef:main Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unconfigured Twilio causes error
4 participants