Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: denver microcenter name #296

Merged
merged 2 commits into from Sep 25, 2020
Merged

Conversation

cbandrow
Copy link
Contributor

Description

Doesn't fix any known issues that I found, but for microcenter.ts, the map of locations had an incorrect location:
['devin', '181'], should instead be ['denver', '181'],

The change should be fixed with this PR. Confirmed the "181" store location via the URL for the Denver store:
image

Testing

New dependencies

@cbandrow cbandrow requested a review from jef as a code owner September 25, 2020 00:26
@@ -10,7 +10,7 @@ const microCenterLocationToId: Map<string, string> = new Map([
['chicago', '151'],
['columbus', '141'],
['dallas', '131'],
['devin', '181'],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol... No idea. Sorry about that. Shout out to the CU Boulders 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol it's all good, thanks for putting this whole thing together. Saw it as an easy way to boost my really limited github score.

@jef jef changed the title fix denver microcenter name. fix: denver microcenter name Sep 25, 2020
@jef jef merged commit 349f55d into jef:main Sep 25, 2020
@jef
Copy link
Owner

jef commented Sep 25, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants