Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): add additional cards to all stores #286

Merged
merged 3 commits into from
Sep 24, 2020
Merged

feat(store): add additional cards to all stores #286

merged 3 commits into from
Sep 24, 2020

Conversation

joshuahiggins
Copy link
Contributor

@joshuahiggins joshuahiggins commented Sep 24, 2020 •
edited

Description

  • Adds additional 3080 and 3090 cards to adorama, asus, bestbuy, b&h, evga, newegg, zotac
  • Adds 3090 FE ID for en-us on Nvidia API
  • Updates existing 3090 cards from bestbuy with add to cart link
  • Adds intl=nosplash to existing 3090 links in bestbuy

Testing

Ran locally and verified that new cards were monitored

New dependencies

N/A

@joshuahiggins joshuahiggins changed the title feat(store): add additional cards to adorama, asus, b&h, evga, newegg, nvidia, zotac feat(store): add additional cards to adorama, asus, bestbuy, b&h, evga, newegg, nvidia, zotac Sep 24, 2020
@joshuahiggins
Copy link
Contributor Author

@jef Merged another PR into this one. This PR is now ready for review.

@jef
Copy link
Owner

jef commented Sep 24, 2020

Wow... That's all of them 😮

@locmai0808
Copy link
Contributor

LGTM!

@joshuahiggins
Copy link
Contributor Author

Can you tell I still haven't snagged a 3000 card yet?

@jef
Copy link
Owner

jef commented Sep 24, 2020

You'll get one

@jef
Copy link
Owner

jef commented Sep 24, 2020

Thanks very much for the update!

@jef jef changed the title feat(store): add additional cards to adorama, asus, bestbuy, b&h, evga, newegg, nvidia, zotac feat(store): add additional cards to all stores Sep 24, 2020
@jef jef merged commit d25a643 into jef:main Sep 24, 2020
@joshuahiggins joshuahiggins deleted the stores branch September 24, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joshuahiggins @jef @locmai0808