Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stores): add 3090s for amazon-ca, bestbuy-ca, newegg-ca #258

Merged
merged 5 commits into from Sep 24, 2020

Conversation

serg06
Copy link
Contributor

@serg06 serg06 commented Sep 23, 2020

Description

  • amazon-ca: Add all 3090s, add new 3080s.
  • bestbuy-ca: Add all 3090s, add new 3080s.
  • newegg-ca: Add all 3090s.

Testing

  • Tried with STORES="bestbuy-ca" SERIES="3080", all classified as OOS.
  • Tried with STORES="bestbuy-ca" SERIES="3090", all classified as OOS.
  • Tried with STORES="newegg-ca" SERIES="3090", all classified as OOS.
  • Tried with STORES="amazon-ca" SERIES="3090", all classified as OOS.

@serg06 serg06 requested a review from jef as a code owner September 23, 2020 23:13
@serg06 serg06 changed the title feat(stores): BestBuy (CA): Update 3080s, add 3090s. feat(stores): Add 3080s and 3090s for BestBuy (CA) and Newegg (CA) Sep 23, 2020
@serg06 serg06 changed the title feat(stores): Add 3080s and 3090s for BestBuy (CA) and Newegg (CA) feat(stores): Add 3090s for Amazon (CA), BestBuy (CA), and Newegg (CA) Sep 23, 2020
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Lets get that card!!!

@jef jef changed the title feat(stores): Add 3090s for Amazon (CA), BestBuy (CA), and Newegg (CA) feat(stores): add 3090s for amazon-ca, bestbuy-ca, newegg-ca Sep 24, 2020
@jef jef merged commit 482fb58 into jef:main Sep 24, 2020
@liuqiaoyi
Copy link

Thank you so much for your work! Now we have a small chance to fight with scalper

@serg06
Copy link
Contributor Author

serg06 commented Sep 24, 2020

Note that the Amazon.ca code is missing from this PR, I think I forgot to push it :(. I'm standing in line for a 3090 so I can't do it right now. I'll do it as soon as I get home (~7:30am PST.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants