Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable auto add to cart #216

Closed
Mo0nbase opened this issue Sep 22, 2020 · 6 comments
Closed

Ability to disable auto add to cart #216

Mo0nbase opened this issue Sep 22, 2020 · 6 comments
Assignees

Comments

@Mo0nbase
Copy link

Description

A simple option to disable the automatic add to cart feature for the nvidia store in the .env config.

@fuckingrobot
Copy link
Contributor

And do what instead @Mo0nbase?

@jef
Copy link
Owner

jef commented Sep 22, 2020

I don't think @Mo0nbase wants a card.

@jef jef changed the title Add Auto Cart for Nvidia store in .env Disable auto add to cart Sep 22, 2020
@jef jef changed the title Disable auto add to cart Ability to disable auto add to cart Sep 22, 2020
@ZohWeiss
Copy link

ZohWeiss commented Sep 23, 2020

Presumably take you to the page for the card to manually click "Add to cart"
It's possible that some stores have bot detection and the automatic add to cart is triggering this, causing orders to be flagged/canceled.

That being said, nVidia.com is also trying to add nothing to the cart and running a false positive right now.

@fuckingrobot
Copy link
Contributor

Are you talking about it opening on start? That's so you can log in before it finds stock. See the log in the terminal.

#226 will make sure it only opens when config is set to open things in the browser

@g1forfun
Copy link
Contributor

When it opens on start, the login for Nvidia doesn't work for me in the window that pops up automatically.

@jef
Copy link
Owner

jef commented Sep 24, 2020

Not an issue right since Nvidia API is washed out. Going to close and will add this feature when we understand the API more.

@jef jef closed this as completed Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants