feat(ldlc): adding ldlc french store #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrToshio
changed the title
MrToshio
changed the title
MrToshio
changed the title
MrToshio
changed the title
jef
reviewed
Feb 27, 2021
Oops, done! :-) |
jef
previously approved these changes
Mar 2, 2021
src/store/model/ldlc.ts
Outdated
Comment on lines
7
to
8
| container: '.stock-1', | ||
| text: ['en', 'stock'], |
There was a problem hiding this comment.
Suggested change
| container: '.stock-1', | |
| text: ['en', 'stock'], | |
| container: '.stock', | |
| text: ['stock'], |
Perhaps we just take this change?
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
nonono, thank YOU very much! :D |
aguilaair
added a commit
to aguilaair/streetmerchant
that referenced
this pull request
Mar 2, 2021
This reverts commit a7be09d.
|
Hello @MrToshio , |
|
Feel free to make a PR. Looks like it's only 3080s. |
Hello, I confirm that I only added the 3080, but yeah feel free to add any other one you feel like adding, don't hesitate to contact me if you are other questions 👍 |
erwinc1
pushed a commit
to erwinc1/streetmerchant
that referenced
this pull request
Mar 31, 2021
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
New dependencies