Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): add globaldata #2004

Merged
merged 2 commits into from Feb 26, 2021
Merged

feat(store): add globaldata #2004

merged 2 commits into from Feb 26, 2021

Conversation

jcalado
Copy link
Contributor

@jcalado jcalado commented Feb 21, 2021

Description

Adds support for a major PC retailer in Portugal, Globaldata

Testing

Tested locally - stock status working.
Can't get maxPrice since the element has   to separate thousands, breaking the regex I guess..

@jcalado jcalado requested a review from jef as a code owner February 21, 2021 12:27
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one suggestion, everything else looks great!

Thank you 💯

src/store/model/globaldata.ts Outdated Show resolved Hide resolved
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@jef jef changed the title feat(store): add globaldata.pt feat(store): add globaldata Feb 26, 2021
@jef jef merged commit 5effbae into jef:main Feb 26, 2021
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants