Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add terraform infra as code for AWS fargate #1987

Merged
merged 16 commits into from Feb 23, 2021
Merged

Conversation

dansweeting
Copy link
Contributor

@dansweeting dansweeting commented Feb 18, 2021

Description

I loved the dockerised app so I got it up and running on AWS Fargate to get myself a ps5. After about three weeks, Street merchant notified me on Slack that Amazon UK had the console in stock, and I checked out with a console, without paying a scalper. Sure I had to pay $50 in AWS fees but that's probably more because I left DEBUG logging switched on for a week :)

So as a thank-you, here's a PR, but this could also just live alongside the project as a spin-off repo.

Testing

I've manually tested this as I've provisioned containers. I was able to check that the container app was running by checking the accompanying CloudWatch dashboard that's included in the terraform provisioning.

. NA . NA

New dependencies

(optional) terraform: v14

@jef
Copy link
Owner

jef commented Feb 21, 2021

Amazing! I'm sure people would LOVE this. I'm going to get a coworker of mine to ensure everything looks OK. I don't know all the ins and outs about Terraform, but it looks good to me.

I definitely would love to see this come in!

Thanks for this contribution and I hope you enjoy your new PS5!

Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, my partner has reviewed. Everything looks good from a code stand point. I personally won't be testing this, but if someone sees this comment in the future and it doesn't work: I'm sorry 😌

That being said, I hope others will contribute if there is anything they can improve upon.

This implementation is great and will really take streetmerchant to the next level!

Thank you for your contribution ☺️


I'll be adding the README to the Mkdocs so it can be accessible via https://jef.codes/streetmerchant. I'll make a reference to when that gets pushed up.

@jef jef merged commit d341ef7 into jef:main Feb 23, 2021
jef added a commit that referenced this pull request Feb 23, 2021
@jef
Copy link
Owner

jef commented Feb 23, 2021

@dansweeting dansweeting deleted the terraform branch February 24, 2021 14:35
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants